feat: support metadata table "history" #841
Draft
+421
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
rshkv
commented
Dec 24, 2024
Comment on lines
+217
to
+231
| impl<'a> Iterator for Ancestors<'a> { | ||
| type Item = &'a SnapshotRef; | ||
|
|
||
| fn next(&mut self) -> Option<Self::Item> { | ||
| if let Some(snapshot) = self.current_snapshot { | ||
| self.current_snapshot = match snapshot.parent_snapshot_id() { | ||
| Some(parent_snapshot_id) => self.table_metadata.snapshot_by_id(parent_snapshot_id), | ||
| None => None, | ||
| }; | ||
| Some(snapshot) | ||
| } else { | ||
| None | ||
| } | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #823. Extends @xxchan's #822 to add support for the History metadata table. (I'll rebase and update this PR once #822 merges.)
The history table is the snapshot log with ancestry information.
Reference implementations: