refactor: avoid async_trait for FileWrite and provide extra dyn methods #762
+80
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Dec 10, 2024
| @@ -213,7 +213,7 @@ impl SchemaVisitor for IndexByParquetPathName { | |||
| pub struct ParquetWriter { | |||
| schema: SchemaRef, | |||
| out_file: OutputFile, | |||
| writer: AsyncArrowWriter<AsyncFileWriter<TrackWriter>>, | |||
| writer: AsyncArrowWriter<AsyncFileWriter<TrackWriter<opendal::Writer>>>, | |||
There was a problem hiding this comment.
I'm reluctant to have 3rd party classes in our API.
There was a problem hiding this comment.
Changed to use a opaque type defined by TAIT to hide the 3rd party type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the same motivation to #760, but for the
FileWritetrait.