Support execution in Windows using Local File System and NFS #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this @rfung777 🙌 Ideally, we would also love to have Windows integration tests on Github Actions. WDYT? |
rfung777
force-pushed
the
feature/support-windows-local-fs-and-nfs
branch
2 times, most recently
from
9c8d7de
to
e9cca42
Compare
|
Thanks for reviewing. New to the Windows integration test in GitHub Actions. I will do a bit of research to see how it is done. |
rfung777
force-pushed
the
feature/support-windows-local-fs-and-nfs
branch
from
e9cca42
to
5228f1c
Compare
|
hi @Fokko , I am not having much luck with setting up the Windows integration tests. It seems to require to install Make and Minio. The changes above seems to be localised in the parser function. Shall we push forward with this? |
rfung777
force-pushed
the
feature/support-windows-local-fs-and-nfs
branch
from
5228f1c
to
42a2e87
Compare
|
I had an attempt of adding the Windows integration tests. Would you help review again please? Thanks. |
|
@rfung777 Sorry, I was out for a while. Let's give it a try 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running PyIceberg in Windows,
pyiceberg.io.pyarrow.PyArrowFileIO.parse_location()incorrectly resolve Windows path, e.g.C:\foobaras a scheme ofCand causesUnrecognized filesystem type in URIerror later.If using
file://scheme, the path is also incorrectly resolved to/C:\foobar. see https://stackoverflow.com/a/43925228