Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: Add more post release notes #983

Merged
merged 7 commits into from
Jul 31, 2024
Merged

DOCS: Add more post release notes #983

merged 7 commits into from
Jul 31, 2024

Conversation

sungwy
Copy link
Collaborator

@sungwy sungwy commented Jul 30, 2024

No description provided.

@sungwy sungwy requested a review from HonahX July 30, 2024 22:18
@sungwy sungwy changed the title DOCS: Add more notes post release notes DOCS: Add more post release notes Jul 30, 2024
@sungwy sungwy requested a review from kevinjqliu July 30, 2024 23:57
kevinjqliu
kevinjqliu approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the release docs! I added a few comments on generating new release notes

mkdocs/docs/how-to-release.md Outdated Show resolved Hide resolved
mkdocs/docs/how-to-release.md Outdated Show resolved Hide resolved
@sungwy sungwy requested a review from kevinjqliu July 31, 2024 02:00
Fokko
Fokko approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @sungwy thanks for cleaning this up 🥳

mkdocs/docs/how-to-release.md Outdated Show resolved Hide resolved
HonahX
HonahX approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sungwy Thanks for updating the doc!

mkdocs/docs/how-to-release.md Outdated Show resolved Hide resolved
kevinjqliu
kevinjqliu reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few notes to the "Github Release Notes" part as I am going through the steps on my own forked repo

mkdocs/docs/how-to-release.md Outdated Show resolved Hide resolved
mkdocs/docs/how-to-release.md Outdated Show resolved Hide resolved
mkdocs/docs/how-to-release.md Show resolved Hide resolved
mkdocs/docs/how-to-release.md Outdated Show resolved Hide resolved
@sungwy
Copy link
Collaborator Author

sungwy commented Jul 31, 2024

I added a few notes to the "Github Release Notes" part as I am going through the steps on my own forked repo

Thanks for these nits, and for taking the time to walk through the directions!

@sungwy sungwy merged commit 3809708 into apache:main Jul 31, 2024
3 of 7 checks passed
@sungwy sungwy deleted the more-release-notes branch July 31, 2024 19:02
@kevinjqliu
Copy link
Contributor

wdyt about running the Github action to update the pyiceberg website so that the docs changes are reflected? Otherwise, this will be updated on the next release

@sungwy
Copy link
Collaborator Author

sungwy commented Jul 31, 2024

wdyt about running the Github action to update the pyiceberg website so that the docs changes are reflected? Otherwise, this will be updated on the next release

Already did! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonahX HonahX HonahX approved these changes

@kevinjqliu kevinjqliu kevinjqliu approved these changes

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sungwy @kevinjqliu @Fokko @HonahX