Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some broken commands and URLs in the docs #89

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Fix some broken commands and URLs in the docs #89

merged 2 commits into from
Oct 21, 2023

Conversation

hussein-awala
Copy link
Member

Fix some broken commands and URLs in the docs after moving the python package to a separate repository.

related: #3

@Fokko Fokko added this to the PyIceberg 0.5.1 release milestone Oct 21, 2023
Fokko
Fokko approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed these when doing the last release, but didn't get to it to create a PR for it, thanks for picking this up! Can you also fix the remaining ones in how-to-release.md on line 57, 109, and 110? Thanks!

@hussein-awala
Copy link
Member Author

I also noticed these when doing the last release, but didn't get to it to create a PR for it, thanks for picking this up! Can you also fix the remaining ones in how-to-release.md on line 57, 109, and 110? Thanks!

Done.

Fokko
Fokko approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this @hussein-awala 🙌

@Fokko Fokko merged commit 16fe631 into apache:main Oct 21, 2023
6 checks passed
Fokko pushed a commit that referenced this pull request Oct 24, 2023
@hussein-awala @Fokko
Fix broken commands and URLs in the docs (#89)
1b186d6 
* Fix some broken commands and URLs in the docs

* Fix broken URLs in how-to-release doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PyIceberg 0.5.1 release
Development

Successfully merging this pull request may close these issues.
2 participants
@hussein-awala @Fokko