New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify S3 config naming convention #1301

Merged

kevinjqliu merged 2 commits into apache:main from kevinjqliu:kevinjqliu/s3-role

Nov 6, 2024

Contributor

kevinjqliu commented Nov 6, 2024 •

edited

Loading

Add role- prefix to session-name (session-name -> role-session-name)
Modified aws. prefix to client. prefix (aws.role-arn -> client.role-arn, aws.session-name -> client.role-session-name) since all other Unified AWS Credentials starts with client. Added to docs as well.

Doc changes:
Under S3

Under Unified AWS Credentials

role-arn and session-name were added in #1296, has not been released so this change is backwards compatible

kevinjqliu added 2 commits

November 6, 2024 10:59


          session-name -> role-session-name


          aws. -> client.

873ee02

Fokko approved these changes

View reviewed changes

Contributor

Fokko commented Nov 6, 2024

@kevinjqliu Great catch, thanks!

kevinjqliu merged commit 2778ec2 into apache:main

7 checks passed

kevinjqliu deleted the kevinjqliu/s3-role branch

November 6, 2024 21:03

kevinjqliu added this to the PyIceberg 0.8.0 release milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet