Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Remove the dead link to pass markdown link check #1220

Closed
wants to merge 1 commit into from
Closed

[Doc] Remove the dead link to pass markdown link check #1220

wants to merge 1 commit into from

Conversation

HonahX
Copy link
Contributor

@HonahX HonahX commented Oct 6, 2024 •
edited
Loading

This PR removes the dead link in contributing.md and make CI pass again.

It also fixes a typo that causing mkdocs build --strict fail with

WARNING -  griffe: .../pyiceberg/table/__init__.py:856: No type or annotation for parameter 'selected_fileds'
WARNING -  griffe:.../pyiceberg/table/__init__.py:856: Parameter 'selected_fileds' does not appear in the function signature

@HonahX HonahX requested a review from kevinjqliu October 6, 2024 08:58
@HonahX HonahX changed the title [Doc] Remove dead link [Doc] Remove the dead link to pass markdown link check Oct 6, 2024
@HonahX
Copy link
Contributor Author

HonahX commented Oct 6, 2024

Already fixed in #1213. Sorry for the confusion, will fix the typo in other PR. Thanks @hussein-awala for revierwing!

@HonahX HonahX closed this Oct 6, 2024
@HonahX HonahX removed the request for review from kevinjqliu October 6, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussein-awala hussein-awala hussein-awala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HonahX @hussein-awala