HTTPCORE-775: The SSLIOSession::write does not handle SSLEngineResult#BUFFER_OVERFLOW #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#BUFFER_OVERFLOW Signed-off-by: Andriy Redko <[email protected]>
ok2c
approved these changes
Jan 13, 2025
| .loadKeyMaterial(keyStoreURL, storePassword.toCharArray(), storePassword.toCharArray()); | ||
|
|
||
| if (protocol != null) { | ||
| sslContextBuilder = sslContextBuilder.setProtocol(protocol); |
There was a problem hiding this comment.
@reta It should be OK to pass null to #setProtocol
| this(scheme, null); | ||
| } | ||
|
|
||
| public H2CoreTransportTest(final URIScheme scheme, final String protocol) { |
There was a problem hiding this comment.
@reta Can we give the variable a better name to make it clearer what protocol it is? tlsVersion or tlsProtocol maybe?
Signed-off-by: Andriy Redko <[email protected]>
|
@reta Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSLIOSession::write does not handle SSLEngineResult#BUFFER_OVERFLOW. The suggested fix it to make sure there is enough place in the output buffer to store
SSLSession#getPacketBufferSize()bytes. Closes https://issues.apache.org/jira/browse/HTTPCORE-775