Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] replace googletagmanager to matomo #2877

Merged
merged 17 commits into from
Jan 9, 2025

Conversation

Aias00
Copy link
Contributor

@Aias00 Aias00 commented Dec 14, 2024

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added doc Improvements or additions to documentation webapp home labels Dec 14, 2024
@Aias00 Aias00 added pending and removed doc Improvements or additions to documentation webapp home labels Dec 14, 2024
@Aias00
Copy link
Contributor Author

Aias00 commented Dec 14, 2024

needs to replace the "siteId"

@github-actions github-actions bot added doc Improvements or additions to documentation webapp home labels Dec 14, 2024
@tomsun28
Copy link
Contributor

needs to replace the "siteId"

I have apply for the siteId, not get reponse yet.

@github-actions github-actions bot removed the home label Jan 3, 2025
@tomsun28
Copy link
Contributor

tomsun28 commented Jan 8, 2025

hi @Aias00 here is the tracking code. siteId 67

<!-- Matomo -->
<script>
 var _paq = window._paq = window._paq || [];
 /* tracker methods like "setCustomDimension" should be called before "trackPageView" */
 _paq.push(["setDoNotTrack", true]);
 _paq.push(["disableCookies"]);
 _paq.push(['trackPageView']);
 _paq.push(['enableLinkTracking']);
 (function() {
   var u="https://analytics.apache.org/";
   _paq.push(['setTrackerUrl', u+'matomo.php']);
   _paq.push(['setSiteId', '67']);
   var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0];
   g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s);
 })();
</script>
<!-- End Matomo Code -->

@tomsun28 tomsun28 linked an issue Jan 8, 2025 that may be closed by this pull request
@tomsun28 tomsun28 added this to the 1.7.0 milestone Jan 8, 2025
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Jan 8, 2025
@Aias00
Copy link
Contributor Author

Aias00 commented Jan 9, 2025

hi @Aias00 here is the tracking code. siteId 67

<!-- Matomo -->
<script>
 var _paq = window._paq = window._paq || [];
 /* tracker methods like "setCustomDimension" should be called before "trackPageView" */
 _paq.push(["setDoNotTrack", true]);
 _paq.push(["disableCookies"]);
 _paq.push(['trackPageView']);
 _paq.push(['enableLinkTracking']);
 (function() {
   var u="https://analytics.apache.org/";
   _paq.push(['setTrackerUrl', u+'matomo.php']);
   _paq.push(['setSiteId', '67']);
   var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0];
   g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s);
 })();
</script>
<!-- End Matomo Code -->

great

@Aias00 Aias00 removed the pending label Jan 9, 2025
@tomsun28 tomsun28 merged commit 037957d into apache:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation good first pull request Good for newcomers webapp
Projects
Development

Successfully merging this pull request may close these issues.

[Question] Consider removing the Google tag manager script in web-app
3 participants