Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1996: Adding Dvorak ES keyboard layout #562

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tetebueno
Copy link

Adding support for Spanish Dvorak keyboard layout included in Ubuntu distributions.

@necouchman
Copy link
Contributor

@tetebueno : Thank you for contributing to this. The changes themselves look good, but you'll need to sign up for a Jira account and create a Jira issue for this change, and then tag the PR and the commit messages with the Jira issue (see other PRs for examples).

Also see: https://guacamole.apache.org/open-source/

@tetebueno tetebueno changed the title Adding Dvorak ES keyboard layout GUACAMOLE-1996: Adding Dvorak ES keyboard layout Oct 24, 2024
@tetebueno
Copy link
Author

@@ -233,6 +233,7 @@ rdp_keymaps = \
$(srcdir)/keymaps/en_gb_qwerty.keymap \
$(srcdir)/keymaps/en_us_qwerty.keymap \
$(srcdir)/keymaps/es_es_qwerty.keymap \
$(srcdir)/keymaps/es_es_dvorak.keymap \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the client-side changes, the es_es_dvorak entry should go above the es_es_qwerty entry...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I'll be checking build failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants