[#5533] fix (trino-connector): Fix the exception of ArrayIndexOutOfBoundsException when execute COMMENT COLUMN command #6182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diqiu50
changed the title
yuqi1129
reviewed
Jan 10, 2025
| @@ -109,17 +110,19 @@ String runQueryOnce(String query) { | |||
| session = builder.build(); | |||
| queryRunner.setSession(session); | |||
| } | |||
| return outputStream.toString(); | |||
|
|
|||
| // avoid the ide capturing the error message as failure | |||
There was a problem hiding this comment.
avoid -> Avoid
ide -> IDE
|
|
||
| public static String toSimpleErrorMessage(Exception e) { | ||
| List<String> lines = e.getMessage().lines().toList(); | ||
| return lines.size() > 1 ? lines.get(0) + lines.get(1) : lines.get(0); |
There was a problem hiding this comment.
Would we only output the first two lines of the error message?
There was a problem hiding this comment.
Yes, the client doesn't need to see the stack trace in the error message.
yuqi1129
approved these changes
Jan 13, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
…undsException when execute COMMENT COLUMN command (#6182) ### What changes were proposed in this pull request? Fix the exception of ArrayIndexOutOfBoundsException when handle error message of IllegalArgumentException ### Why are the changes needed? Fix: #5533 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? IT
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 14, 2025
…utOfBoundsException when execute COMMENT COLUMN command (apache#6182) ### What changes were proposed in this pull request? Fix the exception of ArrayIndexOutOfBoundsException when handle error message of IllegalArgumentException ### Why are the changes needed? Fix: apache#5533 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? IT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the exception of ArrayIndexOutOfBoundsException when handle error message of IllegalArgumentException
Why are the changes needed?
Fix: #5533
Does this PR introduce any user-facing change?
No
How was this patch tested?
IT