[#5902] feat: Add tag failure event to Gravitino server #5944
Conversation
### What changes were proposed in this pull request? Add tag failure event to Gravitino server ### Why are the changes needed? Subtask: apache#5902 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit tests.
core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java
Show resolved
Hide resolved
|
|
||
| public class TagFailureEvent extends FailureEvent { | ||
| public TagFailureEvent(String user, Exception exception) { | ||
| super(user, null, exception); |
There was a problem hiding this comment.
identifier should not be null for tag event.
There was a problem hiding this comment.
What should I pass here?
| DELETE_TAG, | ||
| ALTER_TAG, | ||
| LIST_TAG, | ||
| TAG_EXISTS, |
There was a problem hiding this comment.
TAG_EXISTS not used? please remove it
| throw e; | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public Tag createTag( | ||
| String metalake, String name, String comment, Map<String, String> properties) { | ||
| MetalakeInfo metalakeInfo = new MetalakeInfo(name, comment, properties, null); |
There was a problem hiding this comment.
we should create a TagInfo not MetalakeInfo here
- Removed @SuppressWarnings annotations. - Removed unused OperationType. - Replaced MetalakeInfo with TagInfo. - Refactored TagFailureEvent constructor.
| @@ -7,7 +7,7 @@ public class AlterTagFailureEvent extends TagFailureEvent { | |||
| private final String name; | |||
| private final TagChange[] changes; | |||
| public AlterTagFailureEvent(String user, String metalake, String name, TagChange[] changes, Exception exception) { | |||
| super(user, exception); | |||
| super(user, null, exception); | |||
There was a problem hiding this comment.
please provide a meaning identifier to all failure event, for tag operations the resource identifier is the $metalake.$tagName, for list operations the the resource identifier is the objects which supports list tags, such as $metalake.$metadataObject in listTagsForMetadataObject
There was a problem hiding this comment.
Do I need to replace all String metalake in the TagDispatcher interface, as well as the fields that have been replaced with NameIdentifier in the TagManager, with NameIdentifier and construct the NameIdentifier in operations instead?
There was a problem hiding this comment.
what do you mean about Do I need to replace all String metalake in the TagDispatcher interface?
There was a problem hiding this comment.
I mean, currently TagDispatcher's methods are passing metalake as a String, and then turn it to NameIdentifier in TagManager.
I'm asking about if I should turn it to NameIdentifier earlier in TagOperations and then pass it through event and manager.
There was a problem hiding this comment.
I perfer not changing the interfaces in TagManager
|
event describes what happened to a resource identified by a nameIdentifier,
|
|
|
||
| import org.apache.gravitino.NameIdentifier; | ||
| import org.apache.gravitino.tag.TagChange; | ||
|
|
There was a problem hiding this comment.
please add @DeveloperApi and simple java doc to all tag failure event, please refer to SchemaFailureEvent
| package org.apache.gravitino.listener.api.event; | ||
|
|
||
| import org.apache.gravitino.MetadataObject; | ||
| import org.apache.gravitino.utils.MetadataObjectUtil; |
There was a problem hiding this comment.
please format code ./gradlew spotlessApply
What changes were proposed in this pull request?
Add tag failure event to Gravitino server
Why are the changes needed?
Subtask: #5902
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests.