[#5831] fix(CLI): Fix CLi gives unexpected output when input tag set command

[Abyss-lord]

What changes were proposed in this pull request?

Running the command gcli tag set --metalake metalake_demo or gcli tag remove --metalake metalake_demo gives unexpected output.it should give some help information.

Why are the changes needed?

Fix: #5831

Does this PR introduce any user-facing change?

NO

How was this patch tested?

bin/gcli.sh tag set --metalake demo_metalake 
# output: Malformed entity name.

bin/gcli.sh tag set --tag role1 --property test
# output: This command cannot be executed. The tag set command only supports configuring tag properties or attaching tags to entities.

bin/gcli.sh tag set --tag role1 --value val1
# output: This command cannot be executed. The tag set command only supports configuring tag properties or attaching tags to entities.

bin/gcli.sh tag remove --metalake demo_metalake 
# output: Malformed entity name.

bin/gcli.sh tag set --metalake demo_metalake --name Hive_catalog --tag tagA tagB
# output: Hive_catalog now tagged with tagB,tagA

bin/gcli.sh tag remove --metalake demo_metalake --name Hive_catalog
# output: Hive_catalog removed tags tagB,tagA now tagged with nothing

[Abyss-lord]

hi @justinmclean @xunliu , Could you please take a look when you have time?

[justinmclean]

The logic here is not correct as for instance a table name can be null if you are dealing with a schema or a catalog.

[justinmclean]

This is not making 100% sense to me. There are a couple of things I think can be improved here:

• The output of bin/gcli.sh tag set --metalake demo_metalake should be Missing --name option. as the name argument is missing. The existing code should already do this before this function is called?
• The hasEntity logic seems wrong, and I am not sure what you are trying to check here. Could teh function have a better name?
• In hasEntity I'm not sure why you are checking 3 parts of the name when all sorts of entities can be tagged. Also columns will have a four part name.
• Also there are hasCatalogName, hasTableName, etc methods that would be better to use, if where needed to be used?