-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Revise the glossary documentation #5837
base: main
Are you sure you want to change the base?
Conversation
Please do not break sentences over multiple lines as this breaks some tooling. |
No. I don't agree with this. Long lines are hard to review, hard to maintain, hard to read even in an IDE. |
IDE wrap lines, so that's not really an issue. As I explained elsewhere, if you break up lines, tools like grammar and style checkers that we use will not work. Some people who contribute to this project don't have English as their first language and rely heavily on these tools. |
No. It is an issue, and a very annoying issue. Please refer this comment. |
That change is fine. The issue occurs when you break up a sentence over several lines. |
Okay, let me revise this further. Breaking those long sentences to simple English. |
@justinmclean would you please help to review again? Thanks. |
What changes were proposed in this pull request?
This PR fixes the glossary docs.
Why are the changes needed?
The glossary is reordered for quick reference.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A