Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5192] [Feature] Support Catalog Operation DDL for paimon-catalog #5818

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hdygxsj
Copy link
Contributor

@hdygxsj hdygxsj commented Dec 10, 2024

What changes were proposed in this pull request?

Support Catalog Operation DDL for paimon-catalog

Why are the changes needed?

close #5192

Does this PR introduce any user-facing change?

None

How was this patch tested?

org.apache.gravitino.flink.connector.paimon.TestPaimonPropertiesConverter
org.apache.gravitino.flink.connector.integration.test.paimon.FlinkPaimonCatalogIT

@jerryshao jerryshao requested a review from coolderli December 10, 2024 13:22
@hdygxsj
Copy link
Contributor Author

hdygxsj commented Dec 11, 2024

@coolderli Please have a look

Copy link
Contributor

@coolderli coolderli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdygxsj I have some comments. Lack of implementation for creating catalogs. Thanks.

@FANNG1
Copy link
Contributor

FANNG1 commented Dec 18, 2024

@hdygxsj , #5868 is refactoring flink catalog factory, welcome to review

@FANNG1
Copy link
Contributor

FANNG1 commented Dec 19, 2024

@hdygxsj could you rebase your code?

@hdygxsj
Copy link
Contributor Author

hdygxsj commented Dec 19, 2024

@hdygxsj could you rebase your code?

Done,PHAL

@FANNG1
Copy link
Contributor

FANNG1 commented Dec 20, 2024

@sunxiaojian do you have time to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] [flink-connector] Support Catalog Operation DDL for paimon-catalog
3 participants