Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Add audit CLI command for Model #5962

Closed
VigneshSK17 opened this issue Dec 24, 2024 · 3 comments
Closed

[Subtask] Add audit CLI command for Model #5962

VigneshSK17 opened this issue Dec 24, 2024 · 3 comments
Assignees
@VigneshSK17
Labels
subtask Subtasks of umbrella issue

Comments

@VigneshSK17
Copy link
Contributor

Describe the subtask

Part of an initiative to add Model entity support to CLI

Parent issue

#5959
@VigneshSK17 VigneshSK17 added the subtask Subtasks of umbrella issue label Dec 24, 2024
@VigneshSK17 VigneshSK17 mentioned this issue Dec 24, 2024
Closed
4 tasks
@VigneshSK17
Copy link
Contributor Author

@justinmclean I would like to work on this issue.

@justinmclean
Copy link
Member

Thanks for offering to help, I'm currently on holiday and might be slow to respond.

@VigneshSK17
Copy link
Contributor Author

VigneshSK17 commented Dec 26, 2024 •
edited
Loading

No worries, definitely make sure to enjoy your time off!

I did have a question about this command. Should this audit command also be auditing the ModelVersion, not audit it at all, or should I be making a separate command for ModelVersion?

@VigneshSK17 VigneshSK17 mentioned this issue Dec 30, 2024
Merged
justinmclean pushed a commit that referenced this issue Jan 3, 2025
@VigneshSK17
[#5962] feat(client): added audit cli command model (#6047)
c9d124b 
### What changes were proposed in this pull request?

The audit command is one of the commands suggested by @justinmclean as
part of adding Model entity support for the CLI.

Also includes addition of relevant testing code for Model entity CLI
commands a whole.

### Why are the changes needed?

To add audit functionality for a Model using the CLI

Improvement: #5962 

### Does this PR introduce _any_ user-facing change?

Yes.

The audit command for a model was added.

### How was this patch tested?

Unit tests were added for Model CLI support and ran successfully for the
audit command.
Abyss-lord pushed a commit to Abyss-lord/gravitino that referenced this issue Jan 3, 2025
@VigneshSK17 @Abyss-lord
[apache#5962] feat(client): added audit cli command model (apache#6047)
82a299e 
### What changes were proposed in this pull request?

The audit command is one of the commands suggested by @justinmclean as
part of adding Model entity support for the CLI.

Also includes addition of relevant testing code for Model entity CLI
commands a whole.

### Why are the changes needed?

To add audit functionality for a Model using the CLI

Improvement: apache#5962 

### Does this PR introduce _any_ user-facing change?

Yes.

The audit command for a model was added.

### How was this patch tested?

Unit tests were added for Model CLI support and ran successfully for the
audit command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VigneshSK17 VigneshSK17

Labels
subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinmclean @VigneshSK17