Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Add Model support to Gravitino CLI #5959

Open
4 tasks
justinmclean opened this issue Dec 23, 2024 · 5 comments
Open
4 tasks

[Improvement] Add Model support to Gravitino CLI #5959

justinmclean opened this issue Dec 23, 2024 · 5 comments
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Add Modle entity support for CLI, it would be best if this was broken up into several sub-issues.

  • register/link
  • get and list
  • audit
  • create and delete

See #5600 and other model PRs for more info.

How should we improve?

Add model command to the Gravitino CLI

@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Dec 23, 2024
@VigneshSK17
Copy link

Hi, I'd like to work on this.

Two things to start out:

  1. Just wanted to make sure if the Model implemented in this PR [#5600] feat(API): Add Java API definition for ML model in Gravitino #5612 is the one I should be working with
  2. Which CLI implementation for a MetadataObject should I take the most inspiration from (the best written) if any?

Thanks!

@Abyss-lord
Copy link
Contributor

@VigneshSK17
Would it be possible for me to do two of these commands?

  • register\link
  • get and list
    maybe we should broken up into several sub-issues.

@VigneshSK17
Copy link

@Abyss-lord Yea that works for me.

Added the subtask issues and tagged you for the ones you wanted.
#5960
#5961
#5962
#5963

@Abyss-lord
Copy link
Contributor

thank you!

@justinmclean
Copy link
Member Author

There have been several PRs for the Model. I would use what is currently in the main branch. There are a couple of commands that use MetdataObjects. I'd take a look at the role grant and revoke commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Development

No branches or pull requests

3 participants