Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Setting a tag property in the Gravitino CLi gives unexpected output #5831

Closed
justinmclean opened this issue Dec 11, 2024 · 1 comment · Fixed by #5897
Closed
Assignees
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Running the command gcli tag set --metalake metalake_demo or gcli tag remove --metalake metalake_demo gives unexpected output.

How should we improve?

While nothing is done and no exception occurs, the output could be more user-friendly.

@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Dec 11, 2024
@justinmclean justinmclean changed the title [Improvement] Setting a tag property in teh Gravitino CLi give anexpected output [Improvement] Setting a tag property in the Gravitino CLi give anexpected output Dec 11, 2024
@Abyss-lord
Copy link
Contributor

I would like to work on it.

@justinmclean justinmclean changed the title [Improvement] Setting a tag property in the Gravitino CLi give anexpected output [Improvement] Setting a tag property in the Gravitino CLi gives unexpected output Dec 16, 2024
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 18, 2024
…a tag

Running the command gcli tag set --metalake metalake_demo or gcli tag remove --metalake metalake_demo gives unexpected output.it should give some help information.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 18, 2024
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 18, 2024
…a tag

Running the command gcli tag set --metalake metalake_demo or gcli tag remove --metalake metalake_demo gives unexpected output.it should give some help information.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 18, 2024
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 18, 2024
…a tag

fix some problems according to reviewer.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 18, 2024
… gives an "in use" exception.

Dropping a metalake via the Gravitino CLI gives an "in use" exception.if a metalake in use, it should give some hints.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
… gives an "in use" exception.

Dropping a metalake via the Gravitino CLI gives an "in use" exception.if a metalake in use, it should give some hints.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
… gives an "in use" exception.

Dropping a metalake via the Gravitino CLI gives an "in use" exception.if a metalake in use, it should give some hints.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
…a tag

Running the command gcli tag set --metalake metalake_demo or gcli tag remove --metalake metalake_demo gives unexpected output.it should give some help information.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
…a tag

fix some problems according to reviewer.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
… gives an "in use" exception.

Dropping a metalake via the Gravitino CLI gives an "in use" exception.if a metalake in use, it should give some hints.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
…a tag

Running the command gcli tag set --metalake metalake_demo or gcli tag remove --metalake metalake_demo gives unexpected output.it should give some help information.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
…a tag

fix some problems according to reviewer.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 19, 2024
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 29, 2024
…a tag

1. Change validation code;
2. add method to FullName;
3. fix some error of ErrorMessages;
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 29, 2024
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 30, 2024
justinmclean added a commit that referenced this issue Dec 31, 2024
…command (#5897)

### What changes were proposed in this pull request?

Running the command `gcli tag set --metalake metalake_demo` or `gcli tag
remove --metalake metalake_demo` gives unexpected output.it should give
some help information.

### Why are the changes needed?

Fix: #5831 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

local test + UT.

```bash
gcli tag set -m demo_metalake
# Missing --tag option.

gcli tag set -m demo_metalake --tag tagA
# Missing --name option.

gcli tag remove -m demo_metalake
# Missing --tag option.

gcli tag remove -m demo_metalake --tag tagA
# Missing --name option.

gcli tag set --tag tagA --property test
# Command cannot be executed. The set command only supports configuring tag properties or attaching tags to entity.

gcli tag set --tag tagA --value val1
# Command cannot be executed. The set command only supports configuring tag properties or attaching tags to entity.

gcli tag set --metalake demo_metalake --name Hive_catalog --tag tagB tagC
# Hive_catalog now tagged with tagA,tagB,tagC

gcli tag remove --metalake demo_metalake --name Hive_catalog --tag tagA tagC
# Hive_catalog removed tag(s): [tagA, tagC], now tagged with [tagB]

gcli tag remove --metalake demo_metalake --name Hive_catalog --tag tagA tagB tagC
# Hive_catalog removed tag(s): [tagA, tagC], now tagged with []
```

---------

Co-authored-by: Justin Mclean <[email protected]>
Co-authored-by: Shaofeng Shi <[email protected]>
Co-authored-by: roryqi <[email protected]>
Co-authored-by: Xun <[email protected]>
Co-authored-by: JUN <[email protected]>
Co-authored-by: fsalhi2 <[email protected]>
Co-authored-by: Jerry Shao <[email protected]>
Co-authored-by: Cheng-Yi Shih <[email protected]>
Co-authored-by: Qiming Teng <[email protected]>
Co-authored-by: FANNG <[email protected]>
Co-authored-by: Eric Chang <[email protected]>
Co-authored-by: cai can <[email protected]>
Co-authored-by: caican <[email protected]>
Co-authored-by: Qi Yu <[email protected]>
Co-authored-by: Jimmy Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants