FINERACT-2152: Calculate interest pause on repayment schedule #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksii-novikov-onix
force-pushed
the
FINERACT-2152/calculate-interest-pause-on-repayment-schedule
branch
2 times, most recently
from
4e2abe8 to
421c8f2
Compare
adamsaghy
reviewed
Jan 16, 2025
.../apache/fineract/portfolio/interestpauses/service/InterestPauseWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jan 16, 2025
.../apache/fineract/portfolio/interestpauses/service/InterestPauseWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
oleksii-novikov-onix
force-pushed
the
FINERACT-2152/calculate-interest-pause-on-repayment-schedule
branch
3 times, most recently
from
07103c5 to
4e87585
Compare
|
@oleksii-novikov-onix Kindly resolve the conflicts! |
oleksii-novikov-onix
force-pushed
the
FINERACT-2152/calculate-interest-pause-on-repayment-schedule
branch
from
4e87585 to
869e1ba
Compare
janez89
reviewed
Jan 21, 2025
...n/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculator.java
Outdated
Show resolved
Hide resolved
janez89
reviewed
Jan 21, 2025
...n/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculator.java
Outdated
Show resolved
Hide resolved
janez89
reviewed
Jan 21, 2025
...e/fineract/portfolio/loanaccount/loanschedule/data/ProgressiveLoanInterestScheduleModel.java
Outdated
Show resolved
Hide resolved
janez89
reviewed
Jan 21, 2025
...rc/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/data/InterestPeriod.java
Outdated
Show resolved
Hide resolved
janez89
reviewed
Jan 21, 2025
...che/fineract/portfolio/loanaccount/loanschedule/domain/ProgressiveLoanScheduleGenerator.java
Outdated
Show resolved
Hide resolved
oleksii-novikov-onix
force-pushed
the
FINERACT-2152/calculate-interest-pause-on-repayment-schedule
branch
from
41ac30e to
0a545c0
Compare
oleksii-novikov-onix
force-pushed
the
FINERACT-2152/calculate-interest-pause-on-repayment-schedule
branch
2 times, most recently
from
7f0a743 to
6204bd2
Compare
oleksii-novikov-onix
force-pushed
the
FINERACT-2152/calculate-interest-pause-on-repayment-schedule
branch
from
ef41ed0 to
03a2769
Compare
janez89
approved these changes
Jan 23, 2025
oleksii-novikov-onix
force-pushed
the
FINERACT-2152/calculate-interest-pause-on-repayment-schedule
branch
from
03a2769 to
c1fee3e
Compare
janez89
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented interest pause for a single period and between two periods.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.