Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction idempotency customer docs #2608

Conversation

tapaswenipathak
Copy link
Contributor

@tapaswenipathak tapaswenipathak commented Sep 19, 2022

Description

Ref: openMF/mifos-documentation#14.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

cc @edcable.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@tapaswenipathak tapaswenipathak force-pushed the transaction-idempotency-docs branch from 18cb4dd to 704235c Compare October 10, 2022 03:03
@tapaswenipathak tapaswenipathak marked this pull request as ready for review October 10, 2022 03:03
For banks, Apache Fineract is introducing transaction idempotency, business and
effective date configuration as an addition to currenty supported

* System date
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to mixing up the idempotency concept with dates? I don't get it.

* Tenant date
* User-provided date

Transaction idempotency is the scenario in POST and PUT API requests when if the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only POST and PUT. DELETE/PATCH too.

* VM Crash
* JVM Crash
* Thread exception
* APIs crashe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

* Thread exception
* APIs crashe

* Duplicate writes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indentation.

@tapaswenipathak tapaswenipathak force-pushed the transaction-idempotency-docs branch from 704235c to d4ebd50 Compare October 16, 2022 16:30
@github-actions
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Nov 16, 2022
@github-actions github-actions bot closed this Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants