Add business date customer document #2490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tapaswenipathak are there any plans to make this PR ready? Do you need help with it? |
|
plans: yes. soon, this week most probably, a couple of more or a bunch.
cc @edcable.
…On Monday, August 22, 2022, Arnold Gálovics ***@***.***> wrote:
@tapaswenipathak <https://github.com/tapaswenipathak> are there any plans
to make this PR ready? Do you need help with it?
—
Reply to this email directly, view it on GitHub
<#2490 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7TVISU2HVWDJ2NUB2LGDDV2N3ZHANCNFSM554GBPRQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@tapaswenipathak would be great if you could format the PR title according to this pattern: "FINERACT-XXXX: Title of Jira ticket". If there's no Jira ticket yet and you are unable to create one yourself then please contact me, I'll help out. Thanks. |
|
sure, but i dont't think any jira ticket(s) exist, can you sync w/ Ed on
slack? please loop me in, if there is anything i can help w/.
…On Tuesday, August 23, 2022, Aleksandar Vidakovic ***@***.***> wrote:
@tapaswenipathak <https://github.com/tapaswenipathak> would be great if
you could format the PR title according to this pattern: "FINERACT-XXXX:
Title of Jira ticket". If there's no Jira ticket yet and you are unable to
create one yourself then please contact me, I'll help out. Thanks.
—
Reply to this email directly, view it on GitHub
<#2490 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7TVIWITWO6ZXVFQO4WBZDV2S7MPANCNFSM554GBPRQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
looped in both of you in the email. not sure if there should be one,
multiple or no jira ticket.
On Tuesday, August 23, 2022, Tapasweni Pathak ***@***.***>
wrote:
… sure, but i dont't think any jira ticket(s) exist, can you sync w/ Ed on
slack? please loop me in, if there is anything i can help w/.
On Tuesday, August 23, 2022, Aleksandar Vidakovic ***@***.***>
wrote:
> @tapaswenipathak <https://github.com/tapaswenipathak> would be great if
> you could format the PR title according to this pattern: "FINERACT-XXXX:
> Title of Jira ticket". If there's no Jira ticket yet and you are unable
to
> create one yourself then please contact me, I'll help out. Thanks.
>
> —
> Reply to this email directly, view it on GitHub
> <#2490 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/
AA7TVIWITWO6ZXVFQO4WBZDV2S7MPANCNFSM554GBPRQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#2490 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7TVIV4DOAABFFUYYTQV2TV2TKCTANCNFSM554GBPRQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
tapaswenipathak
force-pushed
the
business-date-customer-focused
branch
from
e676056 to
a4eda61
Compare
tapaswenipathak
changed the title
Ref: Business & Effective Date Separation - https://github.com/apache/fineract/pull/2358/files https://mifosforge.jira.com/wiki/spaces/P/pages/3079733251/Introducing+Business+Date+into+Fineract+community+version Business date specifics ref: - apache@4465e63#diff-e1b53f2fc56caf87d172c6ef76e2d1f1d2774f7601aadd3e214ddcc782ab1f52R81 - apache@4465e63#diff-5564117bc6e7e43d3bc4e0cf2a805ae5102456e44421f5b9c7f384e27ea0268cR39
tapaswenipathak
force-pushed
the
business-date-customer-focused
branch
from
a4eda61 to
88b344a
Compare
galovics
requested changes
Oct 10, 2022
| @@ -0,0 +1,150 @@ | |||
| = Introducing Business Date into Fineract | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
cc @edcable.
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
cc @edcable.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.