-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Task Of [Feature] Move Rest Protocol to SPI Extensions #13958 #306
Conversation
I have test it locally |
I guess there are some checkstyle failures |
Tanks for your help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commitin the pull request should have a meaningful subject line and body.
exist. If the new feature or significant change is committed, please remember to add sample
in dubbo samples project.
mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sureunit-test and integration-test pass.
the Software Donation Guide.