Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add GitHub Actions workflow #300

Merged
merged 12 commits into from
Mar 31, 2024
Merged

Conversation

aofall
Copy link
Contributor

@aofall aofall commented Mar 29, 2024

What is the purpose of the change

Add GitHub Actions workflow for multiple Dubbo-SPI-Extensions versions

apache/dubbo#13865

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@aofall aofall changed the title build: Add build: GitHub Actions workflow Mar 29, 2024
@aofall aofall changed the title build: GitHub Actions workflow build: Add GitHub Actions workflow Mar 29, 2024
@aofall aofall marked this pull request as draft March 29, 2024 11:00
@aofall aofall marked this pull request as ready for review March 29, 2024 11:34
@aofall
Copy link
Contributor Author

aofall commented Mar 29, 2024

@songxiaosheng @AlbumenJ PTAL

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng songxiaosheng merged commit a7aeaf1 into apache:master Mar 31, 2024
16 checks passed
aofall added a commit to aofall/dubbo-spi-extensions that referenced this pull request Mar 31, 2024
* build: upload GitHub ci/cd workflow for push/pr

* build: remove extra spotless format check

* build: create license check config file

* build: add some ignore file for license check

* fix: prepare build-tools

* fix: setup jdk error

* build: add scheduled workflow

* chore: fix missed or incorrect ASF license

* build: add release workflow

* try to fix cache key not found

* try to fix cache key not found

* fix coverage result filename conflict

(cherry picked from commit a7aeaf1)
@aofall aofall deleted the ci-build branch April 1, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants