Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](delete) fix insert into cols should be corresponding to the query output for delete from command #47406 #47454

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #47406

…ry output for delete from command (#47406)

for mow table with `function_column.sequence_col` map, if use `delete
from` command and run into partial update, may get:
```
 errCode = 2, detailMessage = insert into cols should be corresponding to the query output
```
@github-actions github-actions bot requested a review from dataroaring as a code owner January 26, 2025 06:59
@Thearas
Copy link
Contributor

Thearas commented Jan 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 26, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 26, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40784 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7cac0462b6461b3114f21363d1fe47d8aa03f2f9, data reload: false

------ Round 1 ----------------------------------
q1	17570	7355	7234	7234
q2	2048	171	185	171
q3	10593	1101	1134	1101
q4	10565	767	815	767
q5	7773	2895	2851	2851
q6	237	150	148	148
q7	986	612	601	601
q8	9345	1955	2067	1955
q9	6599	6395	6377	6377
q10	7031	2285	2333	2285
q11	461	267	277	267
q12	408	206	207	206
q13	17772	2991	3038	2991
q14	244	214	214	214
q15	611	516	533	516
q16	690	601	606	601
q17	982	579	548	548
q18	7271	6711	6627	6627
q19	1377	1052	988	988
q20	476	212	200	200
q21	3989	3268	3167	3167
q22	1082	969	994	969
Total cold run time: 108110 ms
Total hot run time: 40784 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7267	7209	7213	7209
q2	325	239	239	239
q3	2896	2948	2936	2936
q4	2035	1805	1853	1805
q5	5744	5767	5808	5767
q6	219	144	146	144
q7	2256	1847	1858	1847
q8	3358	3568	3594	3568
q9	8919	8943	8917	8917
q10	3584	3582	3558	3558
q11	606	509	516	509
q12	807	617	608	608
q13	9839	3191	3214	3191
q14	294	269	284	269
q15	569	522	506	506
q16	685	656	651	651
q17	1856	1607	1610	1607
q18	8200	7679	7764	7679
q19	1668	1559	1655	1559
q20	2114	1869	1886	1869
q21	5521	5441	5321	5321
q22	1168	1036	1028	1028
Total cold run time: 69930 ms
Total hot run time: 60787 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198426 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7cac0462b6461b3114f21363d1fe47d8aa03f2f9, data reload: false

query1	1320	942	923	923
query2	6231	2038	2007	2007
query3	10849	4262	4307	4262
query4	66485	28905	23512	23512
query5	4961	446	458	446
query6	392	179	179	179
query7	5526	305	305	305
query8	302	224	233	224
query9	8820	2702	2695	2695
query10	468	288	265	265
query11	17332	15421	15890	15421
query12	161	102	108	102
query13	1447	448	477	448
query14	11008	7402	7401	7401
query15	204	183	182	182
query16	7103	474	495	474
query17	1103	597	642	597
query18	1891	337	327	327
query19	228	167	169	167
query20	119	111	109	109
query21	205	107	113	107
query22	4671	4487	4610	4487
query23	34693	34172	34351	34172
query24	6166	2920	2935	2920
query25	541	444	429	429
query26	657	184	175	175
query27	1919	354	353	353
query28	4293	2471	2445	2445
query29	725	500	485	485
query30	239	162	165	162
query31	1016	821	846	821
query32	66	56	56	56
query33	437	278	273	273
query34	912	516	511	511
query35	844	734	725	725
query36	1079	969	980	969
query37	124	74	77	74
query38	4062	4061	4003	4003
query39	1526	1487	1491	1487
query40	205	105	103	103
query41	52	58	52	52
query42	124	104	100	100
query43	519	485	507	485
query44	1217	844	845	844
query45	186	169	171	169
query46	1142	721	768	721
query47	1981	1884	1947	1884
query48	470	387	387	387
query49	742	399	389	389
query50	838	430	430	430
query51	7314	7246	7131	7131
query52	100	89	92	89
query53	255	181	189	181
query54	563	450	442	442
query55	79	76	72	72
query56	246	237	232	232
query57	1245	1123	1102	1102
query58	209	205	209	205
query59	3268	2957	3084	2957
query60	293	258	250	250
query61	106	103	104	103
query62	846	749	750	749
query63	219	206	186	186
query64	1374	666	658	658
query65	3252	3218	3204	3204
query66	704	298	316	298
query67	15713	15617	15465	15465
query68	4188	590	570	570
query69	444	268	261	261
query70	1189	1145	1166	1145
query71	374	254	250	250
query72	6390	4116	3981	3981
query73	754	343	347	343
query74	10269	9360	9129	9129
query75	3371	2635	2651	2635
query76	1922	1063	989	989
query77	471	274	282	274
query78	10487	9624	9599	9599
query79	1233	602	609	602
query80	920	424	431	424
query81	524	243	236	236
query82	210	122	125	122
query83	163	143	145	143
query84	283	93	87	87
query85	916	299	289	289
query86	367	308	307	307
query87	4437	4311	4325	4311
query88	3780	2394	2353	2353
query89	412	291	289	289
query90	2047	190	185	185
query91	187	151	163	151
query92	60	49	48	48
query93	1897	550	560	550
query94	810	283	304	283
query95	367	263	260	260
query96	612	276	287	276
query97	3343	3161	3147	3147
query98	216	198	197	197
query99	1711	1418	1402	1402
Total cold run time: 317741 ms
Total hot run time: 198426 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.29 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7cac0462b6461b3114f21363d1fe47d8aa03f2f9, data reload: false

query1	0.03	0.02	0.03
query2	0.07	0.04	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.53	0.50	0.50
query6	1.13	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.05	0.03
query9	0.56	0.52	0.49
query10	0.54	0.55	0.57
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.59
query14	2.85	2.84	2.76
query15	0.89	0.84	0.86
query16	0.39	0.38	0.38
query17	1.05	1.04	0.99
query18	0.23	0.21	0.21
query19	1.92	1.86	2.01
query20	0.02	0.02	0.01
query21	15.37	0.59	0.60
query22	2.77	3.44	2.02
query23	16.82	1.05	0.79
query24	4.15	1.23	1.68
query25	0.30	0.21	0.24
query26	0.29	0.14	0.13
query27	0.05	0.04	0.03
query28	9.47	1.12	1.07
query29	12.60	3.29	3.22
query30	0.24	0.05	0.05
query31	2.86	0.39	0.39
query32	3.26	0.47	0.45
query33	3.05	3.01	3.07
query34	17.17	4.44	4.48
query35	4.56	4.52	4.51
query36	0.66	0.48	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 107.14 s
Total hot run time: 33.29 s

@dataroaring dataroaring merged commit 2ebf871 into branch-3.0 Jan 26, 2025
22 checks passed
@github-actions github-actions bot deleted the auto-pick-47406-branch-3.0 branch January 26, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants