-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Add Clang 18/19 Support #47438
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BMJL,orz
Happy new year!
run buildall |
TPC-H: Total hot run time: 32435 ms
|
TPC-DS: Total hot run time: 192999 ms
|
ClickBench: Total hot run time: 30.21 s
|
TeamCity be ut coverage result: |
run p0 |
This doesn't seem correct. @xiaokang any insights? |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unstable pipeline skipped. we can merge it now.
This PR adds support to compile Doris backend with Clang 19.
I've tested this PR with both Clang 16 and Clang 19 using:
(Azure was disabled due to challenges patching deps in
azure-sdk-for-cpp-azure-core_1.10.3
via vcpkg.)I've released a new toolchain with GCC 14 and Clang 19 here: ldb_toolchain.
Happy New Year to the Doris community! 🎉
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)