[Feature](literal)Support TimeLiteral #47319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32300 ms |
TPC-DS: Total hot run time: 195154 ms |
ClickBench: Total hot run time: 30.98 s |
|
run p0 |
1 similar comment
|
run p0 |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32669 ms |
TPC-DS: Total hot run time: 184397 ms |
ClickBench: Total hot run time: 30.49 s |
zclllyybb
reviewed
Jan 24, 2025
| @@ -96,6 +96,9 @@ suite("test_cast") { | |||
| sql "select cast(true as date);" | |||
| result([[null]]) | |||
| } | |||
|
|
|||
| qt_test_cast_to_time "explain select cast('12:30:30' as time)" | |||
There was a problem hiding this comment.
for explain test we should just use explain and contains
zclllyybb
reviewed
Jan 24, 2025
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-H: Total hot run time: 32315 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 192714 ms |
ClickBench: Total hot run time: 30.85 s |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 32492 ms |
TPC-DS: Total hot run time: 191455 ms |
ClickBench: Total hot run time: 30.99 s |
|
run buildall |
TPC-H: Total hot run time: 32532 ms |
TPC-DS: Total hot run time: 191213 ms |
ClickBench: Total hot run time: 30.97 s |
|
TeamCity be ut coverage result: |
zclllyybb
reviewed
Jan 27, 2025
zclllyybb
reviewed
Jan 27, 2025
| check_fold_consistency "cast(cast('11:11:11' as time) as float);" | ||
| check_fold_consistency "cast(cast('11:11:11' as time) as int);" | ||
| check_fold_consistency "cast(cast('11:11:11' as time) as integer);" | ||
| check_fold_consistency "cast(cast('11:11:11' as time) as json);" |
There was a problem hiding this comment.
what's the behaviour of casting to json? as an element? for all check_fold_consistency we should also add a qt_sql command for result consistency.
zclllyybb
reviewed
Jan 27, 2025
| qt_sql "select cast(1111111 as time);" | ||
| qt_sql "select cast('839:00:00' as time);" | ||
| qt_sql "select cast('8385959' as time);" | ||
| qt_sql "select cast(cast('838:59:59' as variant) as time);" |
There was a problem hiding this comment.
also add some value out of bound
zclllyybb
reviewed
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)