Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression-test](framework) fix sql_return_maparray not use alias bug #46674

Merged
merged 3 commits into from
Jan 13, 2025
Merged

[regression-test](framework) fix sql_return_maparray not use alias bug #46674

merged 3 commits into from
Jan 13, 2025

Conversation

shuke987
Copy link
Collaborator

@shuke987 shuke987 commented Jan 9, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Fix the bug in the testing framework, sql_return_maparray will return the wrong column name instead of the alias when handling sql aliases

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987
Copy link
Collaborator Author

shuke987 commented Jan 9, 2025

run buildall

@shuke987 shuke987 changed the title [regression-test](fix) manager case bug [regression-test](framework) fix sql_return_maparray not use alias bug Jan 9, 2025
@shuke987
Copy link
Collaborator Author

shuke987 commented Jan 9, 2025

run buildall

@shuke987
Copy link
Collaborator Author

shuke987 commented Jan 9, 2025

run p0

hubgeter
hubgeter approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@hubgeter hubgeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR approved by anyone and no changes requested.

Al-assad
Al-assad approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@Al-assad Al-assad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wangbo
wangbo previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@shuke987
Copy link
Collaborator Author

run p0

@shuke987
Copy link
Collaborator Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 11, 2025
@yiguolei yiguolei merged commit 5675ba2 into apache:master Jan 13, 2025
25 checks passed
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
@shuke987
[regression-test](framework) fix sql_return_maparray not use alias bug (
4ecf276 
#46674)
yiguolei pushed a commit that referenced this pull request Jan 13, 2025
@github-actions @shuke987
branch-2.1: [regression-test](framework) fix sql_return_maparray not …
60ea8ed 
…use alias bug #46674 (#46891)

Cherry-picked from #46674

Co-authored-by: shuke <[email protected]>
shuke987 added a commit to shuke987/doris that referenced this pull request Jan 17, 2025
@shuke987
[regression-test](framework) fix sql_return_maparray not use alias bug (
c0eede9 
apache#46674)
@shuke987 shuke987 mentioned this pull request Jan 17, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubgeter hubgeter hubgeter approved these changes

@Al-assad Al-assad Al-assad approved these changes

@yiguolei yiguolei yiguolei approved these changes

@wangbo wangbo wangbo left review comments

Assignees
No one assigned
Labels
dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shuke987 @hello-stephen @yiguolei @wangbo @Al-assad @hubgeter @dataroaring