Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](load)when enable_single_replica_load = true, load not failed a… #26503

Merged
merged 1 commit into from
Dec 25, 2023
Merged

[fix](load)when enable_single_replica_load = true, load not failed a… #26503

merged 1 commit into from
Dec 25, 2023

Conversation

xuwei0912
Copy link

…s expected

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@xuwei0912
Copy link
Author

run buildall

Copy link
Contributor

github-actions bot commented Nov 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.27% (7944/20758)
Line Coverage: 30.17% (64479/213735)
Region Coverage: 29.26% (33280/113745)
Branch Coverage: 25.10% (17118/68212)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bac75d92a892d82cfda3df9fb5366c25be9f3c50_bac75d92a892d82cfda3df9fb5366c25be9f3c50/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.08 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17164176787 Bytes

Copy link
Member

@neuyilan neuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Nov 7, 2023

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single replica does not work as this, you should open the config in be too.

@xuwei0912
Copy link
Author

single replica does not work as this, you should open the config in be too.
Yes,I opened it.
This bug can only be triggered when the single replica optimization takes effect.

@dataroaring
Copy link
Contributor

Could you explain it more?

@xuwei0912
Copy link
Author

Could you explain it more?

When enable single replica load, there is only one channel for a tablet, but the number of failed channels used to determine whether it is an intolerable_failure is calculated based on the actual number of replication, which means that even if the all tabletChannel fails, the load task will not fail.

@xiaokang xiaokang marked this pull request as draft December 22, 2023 02:45
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring marked this pull request as ready for review December 25, 2023 09:00
@dataroaring dataroaring merged commit 5f5f002 into apache:branch-2.0 Dec 25, 2023
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants