-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement](detailMessage) add AvailCapacity prompt in detailMessage #26328
Conversation
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
@@ -593,7 +593,7 @@ public Map<Tag, List<Long>> selectBackendIdsForReplicaCreation( | |||
if (!failedEntries.isEmpty()) { | |||
String failedMsg = Joiner.on("\n").join(failedEntries); | |||
throw new DdlException("Failed to find enough backend, please check the replication num," | |||
+ "replication tag and storage medium.\n" + "Create failed replications:\n" + failedMsg); | |||
+ "replication tag and storage medium and AvailCapacity.\n" + "Create failed replications:\n" + failedMsg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ "replication tag and storage medium and AvailCapacity.\n" + "Create failed replications:\n" + failedMsg); | |
+ "replication tag and storage medium and avail capacity of backends.\n" + "Create failed replications:\n" + failedMsg); |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
1 similar comment
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
Could you put an example of output? |
before modification: after modification: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
run feut |
apache#26328) Co-authored-by: xingying01 <[email protected]>
apache#26328) Co-authored-by: xingying01 <[email protected]>
apache#26328) Co-authored-by: xingying01 <[email protected]>
Proposed changes
Issue Number: close #26253
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...