[pipelineX](bug) Fix potential memory access problem (#27326)

apache · Nov 21, 2023 · 7212822 · 7212822
1 parent 016dccb
commit 7212822
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/be/src/pipeline/task_scheduler.cpp b/be/src/pipeline/task_scheduler.cpp
@@ -80,10 +80,12 @@ Status BlockedTaskScheduler::add_blocked_task(PipelineTask* task) {
     if (!static_cast<PipelineXTask*>(task)->push_blocked_task_to_queue()) {
         // put this task into current dependency's blocking queue and wait for event notification
         // instead of using a separate BlockedTaskScheduler.
+        task->set_running(false);
         return Status::OK();
     }
     _blocked_tasks.push_back(task);
     _task_cond.notify_one();
+    task->set_running(false);
     return Status::OK();
 }
 
@@ -337,7 +339,6 @@ void TaskScheduler::_do_work(size_t index) {
         }
 
         auto pipeline_state = task->get_state();
-        task->set_running(false);
         switch (pipeline_state) {
         case PipelineTaskState::BLOCKED_FOR_SOURCE:
         case PipelineTaskState::BLOCKED_FOR_SINK:
@@ -346,6 +347,7 @@ void TaskScheduler::_do_work(size_t index) {
             static_cast<void>(_blocked_task_scheduler->add_blocked_task(task));
             break;
         case PipelineTaskState::RUNNABLE:
+            task->set_running(false);
             static_cast<void>(_task_queue->push_back(task, index));
             break;
         default: