Customize window frame support for dialect #14288
Open
+87
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Customize window frame support for dialect * fix: ignore frame only when frame implies no frame * Add comments. move the window frame determine logic to dialect method * Update datafusion/sql/src/unparser/dialect.rs * Update test case * fix --------- Co-authored-by: Phillip LeBlanc <[email protected]>
alamb
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Makes sense to me -- thanks @Sevenannn and @phillipleblanc (I see your name on one of the commits)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NA
Rationale for this change
Some dialect doesn't support window frames in window function, for example, in dremio, window frame doesn't work with RANK, DENSE_RANK or ROW_NUMBER functions, and would cause error like will cause error like
ROW/RANGE not allowed with RANK, DENSE_RANK or ROW_NUMBER functions.What changes are included in this PR?
Include a method for Dialect determining whether the Dialect support window frame based on the window function name, start_bound, end_bound. When the window frame start_bound and end_bound indicates that no frame is specified in the original query, and the window function requires no window frame to function in the expected way, the window function will be unparsed as None in ast.
Are these changes tested?
Yes
Are there any user-facing changes?
No