Add a hint about normalization in error message (#14089) #14113
Conversation
github-actions
bot
added
sql
datafusion/common/src/error.rs
Outdated
| @@ -167,6 +167,12 @@ impl Display for SchemaError { | |||
| valid_fields, | |||
| } => { | |||
| write!(f, "No field named {}", field.quoted_flat_name())?; | |||
| write!( | |||
| f, | |||
| ". You can use double quotes to refer to the \"{}\" column", | |||
There was a problem hiding this comment.
its not only double quotes, its been 3 symbols at least.
Prob we can refer to case sensitivity instead, sort of
DataFusion column names are case sensitive. For case insensitive mode set datafusion.sql_parser.enable_ident_normalization option
There was a problem hiding this comment.
I think it is important to provide an alternate syntax for users of end systems who can not control the DataFusion settings. For example, for our InfluxDB users they can't set the configuration settings
I suspect the @TheBuilderJR 's users would likely not be able to change this setting
What about something like this (only in cases where the schema contains a column that matches except for case)
Column names are case sensitive. Use double quotes to refer to the "z" column
or set the datafusion.sql_parser.enable_ident_normalization configuration
There was a problem hiding this comment.
Thank you @cj-zhukov and @comphead -- this is going to make DataFusion much easier to use
datafusion/common/src/error.rs
Outdated
| @@ -167,6 +167,12 @@ impl Display for SchemaError { | |||
| valid_fields, | |||
| } => { | |||
| write!(f, "No field named {}", field.quoted_flat_name())?; | |||
| write!( | |||
| f, | |||
| ". You can use double quotes to refer to the \"{}\" column", | |||
There was a problem hiding this comment.
I think it is important to provide an alternate syntax for users of end systems who can not control the DataFusion settings. For example, for our InfluxDB users they can't set the configuration settings
I suspect the @TheBuilderJR 's users would likely not be able to change this setting
What about something like this (only in cases where the schema contains a column that matches except for case)
Column names are case sensitive. Use double quotes to refer to the "z" column
or set the datafusion.sql_parser.enable_ident_normalization configuration
There was a problem hiding this comment.
Thanks @cj-zhukov and @comphead -- this is a great improvement in my opinion
cj-zhukov
deleted the
cj-zhukov/Add-a-hint-about-normalization-in-error-message
branch
Which issue does this PR close?
Closes #14089.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?