fix: expressions doc for ArrayRemove #1356
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that the documentation is incorrect in this case and that array remove is compatible (and tested) for the types that it currently supports. |
kazuyukitanimura
changed the title
|
Thank you @andygrove, changed this PR for updating doc only |
andygrove
approved these changes
Jan 30, 2025
|
Thank you @andygrove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The doc says ArrayRemove is experimental
datafusion-comet/docs/source/user-guide/expressions.md
Line 193 in ea6d950
although array remove is compatible (and tested) for the types that it currently supports
What changes are included in this PR?
Updated the doc
How are these changes tested?
existing test