Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(android): document ZSH setup for macOS Catalina and newer #1360

Conversation

GitToTheHub
Copy link
Contributor

On macOS Catalina and newer, Apple switched from Bash to ZSH. The new file for ".bash_profile" is ".zprofile".

Also the AnroidSDK path is different on a current macOS with the latest Android Studio, but I don't know since when this was changed, or if it was always like this.

Platforms affected

Android on macOS

Motivation and Context

Environment variables on newer macOS system must stored on .zprofile instead of .bash_profile

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor changes.

Do you have any thoughts on my suggestion about possibly removing part of the added content?

www/docs/en/dev/guide/platforms/android/index.md Outdated Show resolved Hide resolved
www/docs/en/dev/guide/platforms/android/index.md Outdated Show resolved Hide resolved
www/docs/en/dev/guide/platforms/android/index.md Outdated Show resolved Hide resolved
@erisu erisu changed the title Add ZSH config for setting environment variables on macOS Catalina and newer doc(android): document ZSH setup for macOS Catalina and newer Nov 6, 2024
…d newer

- On macOS Catalina and newer, Apple switched from Bash to ZSH. The new file for ".bash_profile" is ".zprofile".
- Add samples for the Android-SDK path on macOS and Linux
- Name Linux first and then macOS

Co-Authored-By: エリス <[email protected]>
@GitToTheHub GitToTheHub force-pushed the add-zsh-config-for-setting-environment-variables branch from 07d643f to fd4dc34 Compare November 7, 2024 11:19
Copy link
Contributor Author

@GitToTheHub GitToTheHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took over the suggestions by @erisu and named always first Linux and then macOS. So it's consistent, that always Linux is first described and then macOS and I squashed everything to one commit.

@erisu erisu merged commit 51481fc into apache:master Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants