[CELEBORN-1804] Shuffle environment metrics of RemoteShuffleEnvironment should use Shuffle.Remote metric group #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reswqa
approved these changes
Dec 25, 2024
SteNicholas
force-pushed
the
CELEBORN-1804
branch
2 times, most recently
from
70dbdb4 to
71151ba
Compare
SteNicholas
force-pushed
the
CELEBORN-1804
branch
from
71151ba to
5029052
Compare
SteNicholas
changed the title
reswqa
reviewed
Dec 26, 2024
...common/src/main/java/org/apache/celeborn/plugin/flink/metric/RemoteShuffleMetricFactory.java
Outdated
Show resolved
Hide resolved
...common/src/main/java/org/apache/celeborn/plugin/flink/metric/RemoteShuffleMetricFactory.java
Show resolved
Hide resolved
SteNicholas
force-pushed
the
CELEBORN-1804
branch
from
5029052 to
faac75c
Compare
SteNicholas
force-pushed
the
CELEBORN-1804
branch
from
faac75c to
4688090
Compare
|
@reswqa, @codenohup, |
…nt should use Shuffle.Remote metric group
SteNicholas
force-pushed
the
CELEBORN-1804
branch
from
4688090 to
bbc8904
Compare
|
Merged to main(v0.6.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Shuffle environment metrics of
RemoteShuffleEnvironmentshould useShuffle.Remotemetric group.Why are the changes needed?
Shuffle environment metrics of
RemoteShuffleEnvironmentuses incorrect netty metric group defined asShuffle.Netty. Therefore,RemoteShuffleEnvironmentshould use remote metric group likeShuffle.Remotefor shuffle environment metrics.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.