-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-1737] Support build tez client package #3028
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3028 +/- ##
==========================================
- Coverage 32.99% 32.68% -0.30%
==========================================
Files 331 336 +5
Lines 19842 20032 +190
Branches 1787 1792 +5
==========================================
+ Hits 6545 6546 +1
- Misses 12933 13123 +190
+ Partials 364 363 -1 ☔ View full report in Codecov by Sentry. |
do you plan to have 2 modules likes other clients?
And could you enable the Also, it is better to provide the checking result for the shaded jar.
|
I've updated this PR. |
build/make-distribution.sh
Outdated
|
||
"${BUILD_COMMAND[@]}" | ||
|
||
## flink spark client jars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: seems typo
<module>tests/tez-it</module> | ||
</modules> | ||
<properties> | ||
<tez.version>0.10.3</tez.version> | ||
<tez.version>0.10.2</tez.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've tested this PR on a cluster. Merged into main(v0.6.0).
What changes were proposed in this pull request?
Add Tez packaging script.
Why are the changes needed?
To support build tez client.
Does this PR introduce any user-facing change?
Yes, enable Celeborn with tez support.
How was this patch tested?
Cluster test.