[CELEBORN-1785][CIP-14] Add baseConf to cppClient #3013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FMX Could you kindly review this PR? Thanks a lot. The BaseConf is the building block for CelebornConf, which will be added in next PR. Any suggestion is welcome. |
Copy that. I'll review it ASAP. |
FMX
reviewed
Dec 23, 2024
FMX
reviewed
Dec 23, 2024
|
@FMX thanks a lot, refactored as advised. Any suggestion is welcome. |
FMX
reviewed
Dec 23, 2024
cpp/celeborn/conf/BaseConf.cpp
Outdated
| @@ -26,7 +26,7 @@ namespace fs = std::experimental::filesystem; | |||
| #endif | |||
|
|
|||
| #include "celeborn/conf/BaseConf.h" | |||
| #include "celeborn/utils/CelebornUtils.h" | |||
| // #include "celeborn/utils/CelebornUtils.h" | |||
There was a problem hiding this comment.
Is this an unintended change? After this change, the build failed.
FMX
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add baseConf to cppClient, which is the building block of conf module.
Why are the changes needed?
To support CelebornCpp configuration module in cppClient.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Compilation and UTs.