CASSGO-28 ignore error retry type #1811
Conversation
Rikkuru
changed the title
|
Can you add a test to ensure that the issue is actually fixed? And to prevent regressions. |
joao-r-reis
changed the title
Hello! OK I will try to get to it on this weekend |
Rikkuru
force-pushed
the
issue1808
branch
2 times, most recently
from
68ccfd0
to
5a5bf22
Compare
Added a test. Wanted to let observer know that error was ignored but observer is called before retry policy is checked. there is one more problem - error will not be ignored if we have no more attempts. Added a fix&test for this too |
There was a problem hiding this comment.
Looks good. +1 assuming CI passes.
Please format your commit message following the rules stated in CONTRIBUTING.md and add this JIRA to the CHANGELOG.md in the Fixed section of Unreleased, thanks!
If you can't squash and rewrite the commit message the committer will do it for you when the PR is merged.
We need another committer +1 to merge this.
RetryType Ignore is documented and should work according to the documentation. Error is not returned to caller on ignore but can be seen in ObservedQuery. RetryType should be checked even if RetryPolicy.Attempt returns false, otherwise Ignore will not work on last attempt. Patch by Rikkuru; reviewed by João Reis for CASSGO-28
You mean anyone who've made a commit or apache employee ? |
Committers are people who have write access to the codebase, a PR needs two +1s from committers to get merged ideally and I'm a committer so we need one more. |
Closes #1808