-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASSGO-28 Retry type Ignore is not different from Rethrow (error is still returned) #1808
Comments
Example (on empty cluster , keyspace error is ok for our test ) MyRetryPolicy can return Ignore or Rethrow - it changes nothing
Output
|
need to add ignored error in ObserverdQuery too |
I honestly don't see a use case for |
Hmm other drivers also have |
What version of Cassandra are you using?
Scylla Enterprise 2024.1.8 or scylla 5.1
What version of Gocql are you using?
github.com/gocql/gocql v1.6.0
What version of Go are you using?
go 1.21.11
What did you do?
used RetryType Ignore (https://pkg.go.dev/github.com/gocql/gocql#RetryType) on write query
What did you expect to see?
I expected that query.Exec() would not return error
What did you see instead?
the error is returned.
Maybe the documentation is not clear on how Ignore and Rethrow are different?
I thought Ignore would make it so that Exec does not return error ? Maybe this would be strange on read ops but it can be used on writes (in Downgrading CL retry policy for example ). But they both return error and I don't see any difference between those retry types
Is there any difference in Rethrow and Ignore retry types ?
The text was updated successfully, but these errors were encountered: