Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-4280][Doc] Add OVERWRITE keyword explanation in load command #4213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jeromestein
Copy link
Contributor

Why is this PR needed?

CarbonData supports load overwrite now, but no related testcases or documents take care of this feature, except partition tables.

What changes were proposed in this PR?

Add [OVERWRITE] keyword in dml-of-carbondata.md and explain how to use this feature with a simple example.

Does this PR introduce any user interface change?

  • No

Is any new testcase added?

JIRA Issue: https://issues.apache.org/jira/browse/CARBONDATA-4280

@CarbonDataQA2
Copy link

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5908/

@CarbonDataQA2
Copy link

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4164/

@CarbonDataQA2
Copy link

Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/310/

@@ -266,7 +281,7 @@ CarbonData DML statements are documented here,which includes:
numPartitions = total size of input data / splitSize
```
The default value is 3, and the range is [1, 300].

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert all these changes below in this PR. Space related changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will do it.

​ Example:

```sql
CREATE TABLE carbon_load_overwrite(id int, name string, city string, age int)
Copy link
Contributor

@Indhumathi27 Indhumathi27 Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add example here. Since it is mentioned in syntax, that could be enough


* If run on cluster mode, please upload all input files to distributed file system, for example 'hdfs://' for hdfs.

* [ OVERWRITE ] :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [ OVERWRITE ] :
* If the OVERWRITE keyword is used, then it will overwrite the existing data in the table with new data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants