Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-4058] create or insert data into the carbon table through … #4054

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liyong072
Copy link

…Hive throw NPE

Why is this PR needed?

If the tableprops(in file org/apache/carbondata/hive/CarbonHiveMetastoreListener.scala) does not have org.apache.spark.sql.CarbonSource property, it will throw NPE.

What changes were proposed in this PR?

Changed case ALTER_TABLE in CarbonHiveMetastoreListener. Added a property check(org.apache.spark.sql.CarbonSource) in tableprops

Does this PR introduce any user interface change?

  • No

Is any new testcase added?

  • No

@CarbonDataQA2
Copy link

Can one of the admins verify this patch?

@liyong072 liyong072 closed this Dec 15, 2020
@liyong072 liyong072 changed the title [CARBONDATA-4058]create or insert data into the carbon table through … [CARBONDATA-4058] create or insert data into the carbon table through … Dec 15, 2020
@liyong072 liyong072 reopened this Dec 15, 2020
@ajantha-bhat
Copy link
Member

Add to whitelist

@CarbonDataQA2
Copy link

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5171/

@CarbonDataQA2
Copy link

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3409/

@ajantha-bhat
Copy link
Member

@liyong072 : Can you please add a testcase that cause the issue in this PR?

@CarbonDataQA2
Copy link

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3292/

@CarbonDataQA2
Copy link

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5056/

@CarbonDataQA2
Copy link

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3298/

@CarbonDataQA2
Copy link

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3297/

@CarbonDataQA2
Copy link

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5055/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants