-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CARBONDATA-4058] create or insert data into the carbon table through … #4054
base: master
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
Add to whitelist |
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5171/ |
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3409/ |
@liyong072 : Can you please add a testcase that cause the issue in this PR? |
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3292/ |
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5056/ |
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3298/ |
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3297/ |
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5055/ |
…Hive throw NPE
Why is this PR needed?
If the tableprops(in file org/apache/carbondata/hive/CarbonHiveMetastoreListener.scala) does not have org.apache.spark.sql.CarbonSource property, it will throw NPE.
What changes were proposed in this PR?
Changed case ALTER_TABLE in CarbonHiveMetastoreListener. Added a property check(org.apache.spark.sql.CarbonSource) in tableprops
Does this PR introduce any user interface change?
Is any new testcase added?