Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling send size zerocopy for rdma #2267

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tuvie
Copy link
Contributor

@Tuvie Tuvie commented May 30, 2023

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed: For convenience of debugging, allow user disabling send size zerocopy with gflags rdma_send_zerocopy

Side effects:

  • Performance effects(性能影响): If user does not set rdma_send_zerocopy to false, there is no effect for performance

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@Tuvie Tuvie mentioned this pull request May 30, 2023
@yanglimingcn
Copy link
Contributor

请问什么情况下需要zero copy,什么情况下不能做zero copy呢?

@Tuvie
Copy link
Contributor Author

Tuvie commented May 31, 2023

理论上都应该做zero copy。关闭zery copy主要用来做debug。

@yanglimingcn
Copy link
Contributor

ok

return -1;
}
len = from[current]->copy_to(buf, len);
base::IOBuf tmp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use of undeclared identifier 'base'

@Tuvie Tuvie force-pushed the master branch 3 times, most recently from 726ee54 to 9f7bce0 Compare June 2, 2023 07:44
@wwbmmm
Copy link
Contributor

wwbmmm commented Jun 25, 2023

bazel compile failed:
example/rdma_performance/client.cpp:91: error: undefined reference to 'brpc::rdma::RegisterMemoryForRdma(void*, unsigned long)'
@Tuvie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants