-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python postcommit dependency workflow #33740
Fix python postcommit dependency workflow #33740
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
R: @damccorm |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had one comment, the rest looks good though
postCommitPyDep.dependsOn "testPy39transformers-430" | ||
toxTask "testPy39transformers-447", "py39-transformers-447", "${posargs}" | ||
test.dependsOn "testPy39transformers-447" | ||
postCommitPyDep.dependsOn "testPy39transformers-447" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what the underlying issue is with these dependencies? It would be better to keep one of these as a lower bound if possible so that we are able to test that beam is still compatible with lower versions of transformers. My ideal would be to have 2 tests, one that is testPy39transformers-428
to test our lower bound and one that is testPy39transformers-447
to test our upper bound
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damccorm The tests testPy39transformers-428, 429, 430 were using the latest version of sentence-transformers (3.4.0), which doesn't support these transformers versions. As a result, it pulled the latest transformers 4.48.1, which no longer supports older torch (<2.0.0) versions that we were using, causing the tests to fail.
So I kept tests for:
- transformers 4.28.x (with sentence-transformers 2.2.2, the latest version that supports 4.28)
- transformers 4.47.x (the last version that still supports older torch)
- transformers 4.48.x (the latest overall version, uses upgraded torch).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Issue #30799
Successful run example: https://github.com/akashorabek/beam/actions/runs/12926316024
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.