Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python postcommit dependency workflow #33740

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

akashorabek
Copy link
Collaborator

Issue #30799
Successful run example: https://github.com/akashorabek/beam/actions/runs/12926316024


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@akashorabek akashorabek changed the title Fix python postcommit dependencies workflow Fix python postcommit dependency workflow Jan 23, 2025
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@akashorabek akashorabek requested a review from damccorm January 23, 2025 13:52
@akashorabek
Copy link
Collaborator Author

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had one comment, the rest looks good though

postCommitPyDep.dependsOn "testPy39transformers-430"
toxTask "testPy39transformers-447", "py39-transformers-447", "${posargs}"
test.dependsOn "testPy39transformers-447"
postCommitPyDep.dependsOn "testPy39transformers-447"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what the underlying issue is with these dependencies? It would be better to keep one of these as a lower bound if possible so that we are able to test that beam is still compatible with lower versions of transformers. My ideal would be to have 2 tests, one that is testPy39transformers-428 to test our lower bound and one that is testPy39transformers-447 to test our upper bound

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damccorm The tests testPy39transformers-428, 429, 430 were using the latest version of sentence-transformers (3.4.0), which doesn't support these transformers versions. As a result, it pulled the latest transformers 4.48.1, which no longer supports older torch (<2.0.0) versions that we were using, causing the tests to fail.
So I kept tests for:

  • transformers 4.28.x (with sentence-transformers 2.2.2, the latest version that supports 4.28)
  • transformers 4.47.x (the last version that still supports older torch)
  • transformers 4.48.x (the latest overall version, uses upgraded torch).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 3cb1440 into apache:master Jan 24, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants