Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor grpc #33553

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Vendor grpc #33553

merged 5 commits into from
Jan 15, 2025

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Jan 9, 2025

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can we merge it first?

Technically released artifacts should come from reviewed codes. In the past the vendor release was done in three step merge vendor PR -> build vendored jar on master -> update Beam to use vendored jar. I understand this PR is used to generate https://repository.apache.org/content/repositories/orgapachebeam-1396/ however by the time of vote this comment hasn't been merged

@damccorm damccorm marked this pull request as ready for review January 15, 2025 19:37
@damccorm
Copy link
Contributor Author

Sure, we can merge this - thanks. I think that wasn't clear to me from the docs (maybe I misread), I'll do a pass to see if they need updated after the release

@damccorm damccorm merged commit 15f973f into master Jan 15, 2025
19 checks passed
@damccorm damccorm mentioned this pull request Jan 24, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants