AVRO-4079: Remove not needed libssl trickery, what was required by C# NET 3.1 and 5.0 #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martin-g Forgot to remove some libssl trickery we had in the Dockerfile, which was needed for the old NET Core targets. At the same time I did some minor cleanup regarding to VS Code devcontainer, which was broken and I had to update the logo.png link, which caused build error in my local docker env. Not sure why it did not fail on main. I dont like piggybacking changes, however that images vs icons change was needed for me to get a proper docker based build. |
martin-g
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
AVRO-4079
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation