Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dev/release): Do nanoarrow vendoring using R_BIN instead of R CMD INSTALL on Windows #475

Merged
merged 1 commit into from
May 17, 2024
Merged

chore(dev/release): Do nanoarrow vendoring using R_BIN instead of R CMD INSTALL on Windows #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,12 @@ test_r() {

show_info "Build the R package source tarball"

# Running R CMD INSTALL on the R source directory is the most reliable cross-platform
# method to ensure the proper version of nanoarrow is vendored into the R package.
# Do this in a temporary library so not to overwrite the a user's existing package.
# Run bootstrap.R from within the r subdirectory
pushd r
"$R_BIN" -e 'source("bootstrap.R", echo = TRUE)'
popd

mkdir "$NANOARROW_TMPDIR/tmplib"
"$R_BIN" CMD INSTALL r --preclean --library="$NANOARROW_TMPDIR/tmplib"

# Builds the R source tarball
pushd $NANOARROW_TMPDIR
Expand Down
2 changes: 2 additions & 0 deletions r/.Rbuildignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@
^bootstrap\.R$
^\.cache$
^compile_commands\.json$
^configure\.win$
^configure$
Loading