fix: Ensure that test for increasing offsets is not affected by overflow #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #290.
This PR fixes the check for increasing offsets: previously it calculated a diff between pairs of elements and ensured that the value was > 0. This failed for expressions like
int32_t diff = (int32_t)-2147483648 - (int32_t)2080374784
, where because of overflow,diff
evalutes to> 0
.