Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add pre-commit CI and make sure the repo passes it #261

Merged
merged 8 commits into from
Jul 20, 2023

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Jul 19, 2023

This PR updates the pre-commit added in #260 with a few options and ensures that the repo actually passes CI with it! I've found the ADBC pre-commit hooks to be very useful and look forward to using them here!

@WillAyd Any thoughts on the modifications/CI implementation?

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #261 (1484453) into main (f41a561) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files          63       63           
  Lines        9720     9720           
=======================================
  Hits         8472     8472           
  Misses       1248     1248           
Impacted Files Coverage Δ
r/src/buffer.c 82.53% <0.00%> (ø)
r/src/init.c 100.00% <ø> (ø)
src/nanoarrow/nanoarrow.hpp 98.09% <ø> (ø)
r/src/array.c 95.81% <100.00%> (ø)
r/src/schema.c 92.55% <100.00%> (ø)
src/nanoarrow/array_stream.c 90.90% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paleolimbot paleolimbot marked this pull request as ready for review July 20, 2023 13:23
@WillAyd
Copy link
Contributor

WillAyd commented Jul 20, 2023

Without knowing yet how it is generated the only thing I wonder is if it is worth running against the dist folder, but guessing there is good reason to if you have included here

Nice work - lgtm

@paleolimbot paleolimbot merged commit 42305f4 into apache:main Jul 20, 2023
27 checks passed
@paleolimbot paleolimbot deleted the more-pre-commit-config branch July 20, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants