Skip to content

Commit

Permalink
Do R vendoring using R_BIN instead of R CMD INSTALL
Browse files Browse the repository at this point in the history
  • Loading branch information
paleolimbot committed May 17, 2024
1 parent 02782cb commit 5d6fa47
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 5 additions & 4 deletions dev/release/verify-release-candidate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,12 @@ test_r() {

show_info "Build the R package source tarball"

# Running R CMD INSTALL on the R source directory is the most reliable cross-platform
# method to ensure the proper version of nanoarrow is vendored into the R package.
# Do this in a temporary library so not to overwrite the a user's existing package.
# Run bootstrap.R from within the r subdirectory
pushd r
"$R_BIN" -e 'source("bootstrap.R", echo = TRUE)'
popd

mkdir "$NANOARROW_TMPDIR/tmplib"
"$R_BIN" CMD INSTALL r --preclean --library="$NANOARROW_TMPDIR/tmplib"

# Builds the R source tarball
pushd $NANOARROW_TMPDIR
Expand Down
2 changes: 2 additions & 0 deletions r/.Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@
^bootstrap\.R$
^\.cache$
^compile_commands\.json$
^configure\.win$
^configure$

0 comments on commit 5d6fa47

Please sign in to comment.