feat: ADBC API revision 1.1.0 #971

lidavidm · 2023-08-08T17:04:12Z

Fixes #55.
Fixes #317.
Fixes #318.
Fixes #319.
Fixes #442.
Fixes #458.
Fixes #459.
Fixes #541.
Fixes #620.
Fixes #685.
Fixes #736.
Fixes #755.
Fixes #939.
Fixes #940.
Fixes #942.
Fixes #962.

lidavidm · 2023-08-08T17:05:13Z

It looks like I added #442 to the header but did not implement it, so I'll go do that. Otherwise, this should be ready for review, though I'll also take some time to review the implementation.

lidavidm · 2023-08-08T19:18:24Z

Hmm, it looks like the Linux packages all still have at most Go 1.18. That's a bit of a problem, since then we can't propagate our cancellation error...

lidavidm · 2023-08-08T19:25:34Z

Alright, I'll revert to Go 1.18 (though, leaving Go 1.20 in CI mostly) and instead of context.Cause rely on exact comparison with context.Canceled and context.DeadlineExceeded

lidavidm · 2023-08-08T21:19:14Z

@zeroshade this is ready for review. I'll be posting to the ML this week for voting unless I hear objections.

paleolimbot

This is very exciting! I'm particularly excited for cancellation and progress options since these are frequently requested features for general database access in R that have long been unresolved.

adbc.h

paleolimbot · 2023-08-09T16:13:38Z

I think this has come up in some other discussion; however, just a note for the record that I'm looking forward to implementing the R bindings on top of this! Since the R bindings are a (very) thin wrapper around the C header, I think it makes sense to vote on this without R and I will implement the required changes for the first ADBC libraries release that implements it 🙂 .

lidavidm · 2023-08-09T16:29:41Z

I think the Snowflake test failures are the two test runs colliding with each other.

.github/workflows/integration.yml

zeroshade · 2023-08-10T20:16:34Z

.github/workflows/native-unix.yml

-          go-version-file: 'go/adbc/go.mod'
+          go-version: 1.20.7


any particular reason to specify the version explicitly instead of pull it from the go.mod?

I've been through this already in prior PRs, I'm not really interested in redoing all this. (+ it's annoying trying to use an old Go since it's tied to the version of golangci-lint.)

Reverted, though I'll have to figure out staticcheck and golangci-lint again...

we can just bump the go.mod to be 1.20 and use the newer golangci-lint and staticcheck

We can't, because debian etc. only have go 1.18

again, I had to go through this all in the previous PR 😬

zeroshade

Most of everything has already been reviewed before it was merged into this branch in the first place. Did a quick look over everything and nothing stands out as problematic or as having had an issue during the merge. so it all LGTM 😄

Thanks for all the work here @lidavidm I know it wasn't easy coordinating all this.

lidavidm · 2023-08-11T14:05:43Z

I realized I forgot about #417 so I'll grab that, assume we're OK with declaring that parameter const @zeroshade?

Fixes #317. --------- Co-authored-by: Matt Topol <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]>

- Clarify one of the docstrings - Remove the 'future growth' padding since we have a different compatibility strategy

Requires #692.

Intends to tackle: - #621 - #685 - #736 - #755

- ADBC_INFO_DRIVER_ADBC_VERSION - StatementExecuteSchema (#318) - ADBC_CONNECTION_OPTION_CURRENT_{CATALOG, DB_SCHEMA} (#319) - Get/SetOption - error_details (#755) - GetStatistics (#685) - New ingest modes (#541)

- ADBC_INFO_DRIVER_ADBC_VERSION - StatementExecuteSchema (#318) - ADBC_CONNECTION_OPTION_CURRENT_{CATALOG, DB_SCHEMA} (#319) - error_details (#755) - GetStatistics (#685)

Fixes #928. Fixes #929.

- ADBC_INFO_DRIVER_ADBC_VERSION - StatementExecuteSchema (#318) - ADBC_CONNECTION_OPTION_CURRENT_{CATALOG, DB_SCHEMA} (#319) - Cancellation - Get/SetOption - New ingest modes

lidavidm · 2023-08-28T14:02:01Z

Filed #995 for the error in the Documentation pipeline

lidavidm added this to the ADBC API Specification 1.1.0 milestone Aug 8, 2023

lidavidm marked this pull request as ready for review August 8, 2023 17:05

lidavidm requested review from kou, zeroshade and paleolimbot as code owners August 8, 2023 17:05

lidavidm mentioned this pull request Aug 8, 2023

feat(c/driver_manager): support alternate entrypoint name #972

Merged

lidavidm force-pushed the spec-1.1.0 branch 2 times, most recently from e65e69e to 7f79f2b Compare August 8, 2023 20:22

paleolimbot reviewed Aug 9, 2023

View reviewed changes

adbc.h Outdated Show resolved Hide resolved

lidavidm force-pushed the spec-1.1.0 branch from 6e2c0c6 to 53eb3f9 Compare August 10, 2023 19:42

zeroshade reviewed Aug 10, 2023

View reviewed changes

.github/workflows/integration.yml Outdated Show resolved Hide resolved

zeroshade reviewed Aug 10, 2023

View reviewed changes

.github/workflows/integration.yml Outdated Show resolved Hide resolved

zeroshade reviewed Aug 10, 2023

View reviewed changes

zeroshade approved these changes Aug 10, 2023

View reviewed changes

lidavidm force-pushed the spec-1.1.0 branch 2 times, most recently from 445d8be to ca4f151 Compare August 10, 2023 23:50

lidavidm mentioned this pull request Aug 11, 2023

fix(format): clarify const-ness of some pointers #417

Closed

lidavidm and others added 6 commits August 28, 2023 09:30

feat(format): introduce ADBC API revision 1.1.0 (#692)

1126b99

Fixes #317. --------- Co-authored-by: Matt Topol <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]>

feat(format): remove unnecessary padding (#731)

e14839a

- Clarify one of the docstrings - Remove the 'future growth' padding since we have a different compatibility strategy

test(c): add backwards compatibility tests for 1.1.0/1.0.0 (#698)

87821ff

Requires #692.

feat(format): add additional features to 1.1.0 spec (#765)

f3fc044

Intends to tackle: - #621 - #685 - #736 - #755

feat(c): fix typos in 1.1.0, update driver manager (#857)

ef10d12

feat(go/adbc): implement ADBC 1.1.0 features (#700)

49a1e7e

- ADBC_INFO_DRIVER_ADBC_VERSION - StatementExecuteSchema (#318) - ADBC_CONNECTION_OPTION_CURRENT_{CATALOG, DB_SCHEMA} (#319) - Get/SetOption - error_details (#755) - GetStatistics (#685) - New ingest modes (#541)

lidavidm and others added 22 commits August 28, 2023 09:30

feat(go/adbc): add FFI support for 1.1.0 features (#893)

a2930a7

feat(java): implement 1.1.0 features (#872)

3047c0c

- ADBC_INFO_DRIVER_ADBC_VERSION - StatementExecuteSchema (#318) - ADBC_CONNECTION_OPTION_CURRENT_{CATALOG, DB_SCHEMA} (#319) - error_details (#755) - GetStatistics (#685)

chore(go): fix up minor Go things in 1.1.0 draft (#926)

b0e07e8

docs: update prose for 1.1.0 and clarify cancellation (#932)

034957b

Fixes #928. Fixes #929.

feat(c/driver/postgresql): implement ADBC 1.1.0 features (#852)

ac012dd

- ADBC_INFO_DRIVER_ADBC_VERSION - StatementExecuteSchema (#318) - ADBC_CONNECTION_OPTION_CURRENT_{CATALOG, DB_SCHEMA} (#319) - Cancellation - Get/SetOption - New ingest modes

feat(python): expose ADBC 1.1.0 features (#937)

31b5b4e

fix(go/adbc/driver/snowflake): disable statistics tests (#944)

1b24ff0

feat(c,format,python): implement error details (#954)

574b7d8

feat(c/driver/postgresql): implement statistics API (#960)

92b54a0

feat(go/adbc/pkg): update error_details FFI (#961)

0fb5310

feat(format,c,go,python): add error details to ArrowArrayStream (#963)

3778c36

feat(c/driver_manager): support alternate entrypoint name (#972)

22ff513

chore: CI fixes, downgrade to Go 1.18

0e07417

chore: link libresolv on macOS

290c4a6

chore: fix typecheck

d3289d4

chore: fix check

e98ea0d

chore: fix test

e26acca

feat: clarify progress

f242e2b

chore: revert R

1781ce1

chore: revert staticcheck/golangci-lint

3984589

fix(format): clarify const-ness of some pointers

29905d3

chore: fix R warnings

ad41b74

lidavidm force-pushed the spec-1.1.0 branch from fdcb31c to ad41b74 Compare August 28, 2023 13:31

chore: fix Flight SQL integration test

e3cb5a8

lidavidm merged commit ba7032d into main Aug 28, 2023
76 of 77 checks passed

lidavidm deleted the spec-1.1.0 branch August 28, 2023 14:56

lidavidm modified the milestones: ADBC API Specification 1.1.0, ADBC Libraries 0.7.0 Aug 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ADBC API revision 1.1.0 #971

feat: ADBC API revision 1.1.0 #971

lidavidm commented Aug 8, 2023 •

edited

Loading

lidavidm commented Aug 8, 2023 •

edited

Loading

lidavidm commented Aug 8, 2023

lidavidm commented Aug 8, 2023

lidavidm commented Aug 8, 2023

paleolimbot left a comment

paleolimbot commented Aug 9, 2023

lidavidm commented Aug 9, 2023

zeroshade Aug 10, 2023

lidavidm Aug 10, 2023

lidavidm Aug 10, 2023

zeroshade Aug 10, 2023

lidavidm Aug 10, 2023

lidavidm Aug 10, 2023

zeroshade left a comment

lidavidm commented Aug 11, 2023

lidavidm commented Aug 28, 2023

feat: ADBC API revision 1.1.0 #971

feat: ADBC API revision 1.1.0 #971

Conversation

lidavidm commented Aug 8, 2023 • edited Loading

lidavidm commented Aug 8, 2023 • edited Loading

lidavidm commented Aug 8, 2023

lidavidm commented Aug 8, 2023

lidavidm commented Aug 8, 2023

paleolimbot left a comment

Choose a reason for hiding this comment

paleolimbot commented Aug 9, 2023

lidavidm commented Aug 9, 2023

zeroshade Aug 10, 2023

Choose a reason for hiding this comment

lidavidm Aug 10, 2023

Choose a reason for hiding this comment

lidavidm Aug 10, 2023

Choose a reason for hiding this comment

zeroshade Aug 10, 2023

Choose a reason for hiding this comment

lidavidm Aug 10, 2023

Choose a reason for hiding this comment

lidavidm Aug 10, 2023

Choose a reason for hiding this comment

zeroshade left a comment

Choose a reason for hiding this comment

lidavidm commented Aug 11, 2023

lidavidm commented Aug 28, 2023

lidavidm commented Aug 8, 2023 •

edited

Loading

lidavidm commented Aug 8, 2023 •

edited

Loading